Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive join no path tracking optimizer #1547

Merged
merged 1 commit into from
May 18, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR implements the optimization where path tracking is not needed in recursive join.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 97.37% and project coverage change: +0.02 🎉

Comparison is base (996b1e1) 92.00% compared to head (76d408a) 92.02%.

❗ Current head 76d408a differs from pull request most recent head fa8dcd6. Consider uploading reports for the commit fa8dcd6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
+ Coverage   92.00%   92.02%   +0.02%     
==========================================
  Files         696      697       +1     
  Lines       24864    24977     +113     
==========================================
+ Hits        22875    22984     +109     
- Misses       1989     1993       +4     
Impacted Files Coverage Δ
...include/optimizer/projection_push_down_optimizer.h 100.00% <ø> (ø)
...ude/processor/operator/recursive_extend/frontier.h 81.48% <81.48%> (ø)
...processor/operator/recursive_extend/path_scanner.h 94.73% <93.75%> (-5.27%) ⬇️
src/common/vector/auxiliary_buffer.cpp 100.00% <100.00%> (ø)
src/include/common/vector/auxiliary_buffer.h 90.00% <100.00%> (+1.11%) ⬆️
src/include/common/vector/value_vector.h 96.29% <100.00%> (+0.14%) ⬆️
...l_plan/logical_operator/logical_recursive_extend.h 100.00% <100.00%> (ø)
...de/processor/operator/recursive_extend/bfs_state.h 100.00% <100.00%> (+5.66%) ⬆️
...ocessor/operator/recursive_extend/recursive_join.h 100.00% <100.00%> (ø)
...or/recursive_extend/shortest_path_recursive_join.h 100.00% <100.00%> (ø)
... and 9 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit e49d980 into master May 18, 2023
5 checks passed
@andyfengHKU andyfengHKU deleted the recursive-join-optimizer branch May 18, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants