Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI Runner for windows take 2 #1544

Closed
wants to merge 26 commits into from
Closed

Add CI Runner for windows take 2 #1544

wants to merge 26 commits into from

Commits on May 16, 2023

  1. Add Windows Support

    @mewim @benjaminwinger
    mewim authored and benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ec49bf9 View commit details
    Browse the repository at this point in the history

  2. Use a shared_ptr instead of unique_ptr for ListsUpdatesPerNode 

    MSVC doesn't allow maps inside vectors to have non-copyable values
    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    758d404 View commit details
    Browse the repository at this point in the history

  3. Set _USE_MATH_DEFINES in both Debug and Release builds on Windows

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b63f95b View commit details
    Browse the repository at this point in the history

  4. Define ARROW_STATIC and PARQUET_STATIC prior to importing their heade… 

    …rs on windows

Otherwise, the headers will declare functions __declspec(dllimport) rather than __declspec(dllexport), as required by the static libs
    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    866ea15 View commit details
    Browse the repository at this point in the history

  5. Fix Makefile Windows commands

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b14a487 View commit details
    Browse the repository at this point in the history

  6. Fixed test compilation on windows

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    7c33aec View commit details
    Browse the repository at this point in the history

  7. Open files in binary mode in Windows

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    5dcf3d5 View commit details
    Browse the repository at this point in the history

  8. Fix string case in antlr4 Debug comparison

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dc1c5f4 View commit details
    Browse the repository at this point in the history

  9. Fix for closing file descriptors (from ziyi chen)

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b02c240 View commit details
    Browse the repository at this point in the history

  10. Implement simple glob without globbing on windows pending cross-platf… 

    …orm solution
    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    3669fb5 View commit details
    Browse the repository at this point in the history

  11. Implemented Windows equivalent of mmap in the buffer manager

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    30a53ed View commit details
    Browse the repository at this point in the history

  12. More ambiguous symbols on Windows

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    5467765 View commit details
    Browse the repository at this point in the history

  13. Windows alternative to mmap for NpyReader

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9767374 View commit details
    Browse the repository at this point in the history

  14. Namespace C API kuzu_data_typeid enum as its members conflict with wi… 

    …ndows headers (namespace pollution)
    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    914c172 View commit details
    Browse the repository at this point in the history

  15. Sleep function on windows

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    0c51707 View commit details
    Browse the repository at this point in the history

  16. Use VirtualAlloc instead of CreateFileMappingW in the VMRegion on Win… 

    …dows
    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    899639f View commit details
    Browse the repository at this point in the history

  17. Use cross-platform glob library to better support globbing on windows

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    2494238 View commit details
    Browse the repository at this point in the history

  18. Revert change from 85bc898

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    3beb8c0 View commit details
    Browse the repository at this point in the history

  19. Fix test bugs

    @acquamarin @benjaminwinger
    acquamarin authored and benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    200c885 View commit details
    Browse the repository at this point in the history

  20. Don't seek in windows file I/O so that the functions are thread-safe

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ce4e8ac View commit details
    Browse the repository at this point in the history

  21. MSVC doesn't like this for some reason

    @benjaminwinger
    benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    4e2f97c View commit details
    Browse the repository at this point in the history

  22. Update ci-workflow.yml

    @mewim @benjaminwinger
    mewim authored and benjaminwinger committed May 16, 2023
    Configuration menu
    Copy the full SHA
    906ed02 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Skip reading from file if the file size is 0

    @acquamarin
    acquamarin committed May 17, 2023
    Configuration menu
    Copy the full SHA
    9adaf7d View commit details
    Browse the repository at this point in the history

  2. Use CreateFile for opening files on windows

    @benjaminwinger
    benjaminwinger committed May 17, 2023
    Configuration menu
    Copy the full SHA
    bacf7f3 View commit details
    Browse the repository at this point in the history

  3. Fixed overlapped structure initialization

    @benjaminwinger
    benjaminwinger committed May 17, 2023
    Configuration menu
    Copy the full SHA
    b24eb48 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Fix wal replay logic

    @acquamarin
    acquamarin committed May 18, 2023
    Configuration menu
    Copy the full SHA
    186a81e View commit details
    Browse the repository at this point in the history