Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undirected query for single label Nodes/Rels #1542

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

aziz-mu
Copy link
Contributor

@aziz-mu aziz-mu commented May 15, 2023

This PR adds support for undirected queries of the form:
MATCH (A)-[N]-(A) ...
where A and N refer to only one node / rel table, respectively.

@aziz-mu aziz-mu requested a review from andyfengHKU May 15, 2023 20:47
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 98.07% and project coverage change: +0.14 🎉

Comparison is base (e9e27a1) 91.85% compared to head (2a8cbf5) 91.99%.

❗ Current head 2a8cbf5 differs from pull request most recent head a63026a. Consider uploading reports for the commit a63026a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1542      +/-   ##
==========================================
+ Coverage   91.85%   91.99%   +0.14%     
==========================================
  Files         689      696       +7     
  Lines       24668    24861     +193     
==========================================
+ Hits        22658    22872     +214     
+ Misses       2010     1989      -21     
Impacted Files Coverage Δ
...rocessor/operator/scan/generic_scan_rel_tables.cpp 93.47% <93.75%> (ø)
.../processor/operator/scan/generic_scan_rel_tables.h 100.00% <100.00%> (ø)
src/planner/join_order_enumerator.cpp 98.13% <100.00%> (+<0.01%) ⬆️
src/processor/mapper/map_extend.cpp 97.97% <100.00%> (+0.38%) ⬆️

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
test/test_files/demo_db/demo_db.test Show resolved Hide resolved
test/test_files/demo_db/demo_db.test Outdated Show resolved Hide resolved
test/test_files/tinysnb/match/undirected.test Outdated Show resolved Hide resolved
src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
@aziz-mu aziz-mu merged commit 3c954b1 into master May 17, 2023
7 checks passed
@aziz-mu aziz-mu deleted the undirected-query branch May 17, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants