Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework column scan and lookup functions #1539

Merged
merged 1 commit into from
May 15, 2023
Merged

Rework column scan and lookup functions #1539

merged 1 commit into from
May 15, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented May 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 99.18% and project coverage change: -0.11 ⚠️

Comparison is base (4f75391) 91.95% compared to head (bb12971) 91.85%.

❗ Current head bb12971 differs from pull request most recent head 96706a0. Consider uploading reports for the commit 96706a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
- Coverage   91.95%   91.85%   -0.11%     
==========================================
  Files         689      689              
  Lines       24672    24676       +4     
==========================================
- Hits        22688    22666      -22     
- Misses       1984     2010      +26     
Impacted Files Coverage Δ
src/storage/storage_structure/column.cpp 91.02% <98.95%> (+1.86%) ⬆️
src/include/storage/storage_structure/column.h 96.77% <100.00%> (+2.20%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 marked this pull request as ready for review May 15, 2023 02:49
src/storage/storage_structure/column.cpp Outdated Show resolved Hide resolved
@ray6080 ray6080 merged commit e9e27a1 into master May 15, 2023
5 checks passed
@ray6080 ray6080 deleted the column-rework branch May 15, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants