-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive path #1538
Recursive path #1538
Conversation
67f1bb0
to
ae70e7f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
+ Coverage 91.84% 91.96% +0.11%
==========================================
Files 689 691 +2
Lines 24670 24616 -54
==========================================
- Hits 22659 22638 -21
+ Misses 2011 1978 -33
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our discussion, I would still improve on these:
- Try to implement a iterative version that also can write multiple paths into ValueVectors inside the FixedLengthPathScanner. You might want to benchmark these optimizations to see if they matter but they're common wisdom I think.
- I would add more comments to clarify how the entire algorithm will work. You would need to clarify that: (i) Why do you need multiple FixedLengthPathScanners? (ii) where you go over multiple FixedLengthPathScanners? and (iii) More comments inside the FixedSizePathScanner::getNext() function to clarify the high-level logic.
Also, it would be good to have @anuchak review the PR too. It would help him familiarize himself and see our discussions.
42d39ef
to
875a0d8
Compare
This PR keeps track of path (currently implemented as
LIST[INTERNAL_ID]
) for recursive join