Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null to struct fields #1533

Merged
merged 1 commit into from
May 11, 2023
Merged

Add null to struct fields #1533

merged 1 commit into from
May 11, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented May 11, 2023

This PR adds null to struct fields.

@acquamarin acquamarin requested a review from ray6080 May 11, 2023 01:20
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 98.07% and project coverage change: +0.01 🎉

Comparison is base (4c2ac16) 91.95% compared to head (d7eee9c) 91.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
+ Coverage   91.95%   91.97%   +0.01%     
==========================================
  Files         687      687              
  Lines       24525    24547      +22     
==========================================
+ Hits        22553    22576      +23     
+ Misses       1972     1971       -1     
Impacted Files Coverage Δ
src/include/common/null_buffer.h 100.00% <ø> (ø)
...include/function/struct/vector_struct_operations.h 100.00% <ø> (ø)
src/processor/result/factorized_table.cpp 95.21% <ø> (ø)
...c/storage/storage_structure/disk_overflow_file.cpp 92.44% <ø> (ø)
src/function/vector_struct_operations.cpp 92.98% <96.15%> (+2.65%) ⬆️
src/common/types/types.cpp 94.69% <100.00%> (+0.01%) ⬆️
src/common/types/value.cpp 93.20% <100.00%> (+0.05%) ⬆️
src/common/vector/value_vector_utils.cpp 100.00% <100.00%> (ø)
src/storage/copier/rel_copy_executor.cpp 94.46% <100.00%> (ø)
...ge/in_mem_storage_structure/in_mem_node_column.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/common/types/types.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit bc8fa44 into master May 11, 2023
7 checks passed
@acquamarin acquamarin deleted the struct-null branch May 11, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants