-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list_sum and list_sort functions #1529
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1529 +/- ##
========================================
Coverage 91.95% 91.96%
========================================
Files 687 689 +2
Lines 24502 24665 +163
========================================
+ Hits 22532 22683 +151
- Misses 1970 1982 +12
☔ View full report in Codecov by Sentry. |
8a3bb51
to
052d092
Compare
052d092
to
767814a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See my comment about refactoring the list_sort operation.
- Add more tests to improve test coverages.
- We already have an orderBy operator which implements our own sorting algorithm. We should reuse the orderBy operator inside list_sort. Can you open an issue about this?
5ea798b
to
2ad3acb
Compare
2ad3acb
to
d543bf9
Compare
d543bf9
to
31d9516
Compare
31d9516
to
f987264
Compare
Added functions:
list_sort(list)
Sorts the elements of the list.
Examples:
list_sum(list)
Returns the sum of all elements in the list