Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undirected query logical changes #1528

Merged
merged 1 commit into from
May 12, 2023
Merged

Undirected query logical changes #1528

merged 1 commit into from
May 12, 2023

Conversation

aziz-mu
Copy link
Contributor

@aziz-mu aziz-mu commented May 10, 2023

First step to support queries such as MATCH (a:User)-[:Follows]-(b:User) RETURN a.name

Changes made:

  • Added parser support to support undirected query syntax
  • Modify binder to support undirected query edges
  • Modify RelExpression / LogicalExtend to be able to tell if a relation is directed or undirected

Note: Currently the correct behaviour of any undirected query is not implemented

@aziz-mu aziz-mu requested a review from andyfengHKU May 10, 2023 15:42
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 95.74% and project coverage change: +0.02 🎉

Comparison is base (6dd34cc) 91.93% compared to head (961330d) 91.95%.

❗ Current head 961330d differs from pull request most recent head 7f1f767. Consider uploading reports for the commit 7f1f767 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
+ Coverage   91.93%   91.95%   +0.02%     
==========================================
  Files         680      687       +7     
  Lines       24543    24556      +13     
==========================================
+ Hits        22564    22581      +17     
+ Misses       1979     1975       -4     
Impacted Files Coverage Δ
src/include/catalog/catalog.h 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
...c/include/parser/query/graph_pattern/rel_pattern.h 100.00% <ø> (ø)
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
...ner/logical_plan/logical_operator/logical_extend.h 100.00% <ø> (ø)
...l_plan/logical_operator/logical_recursive_extend.h 100.00% <ø> (ø)
src/include/storage/copier/rel_copy_executor.h 100.00% <ø> (ø)
...orage/storage_structure/lists/lists_update_store.h 100.00% <ø> (ø)
src/include/storage/storage_utils.h 100.00% <ø> (ø)
src/include/storage/store/rels_store.h 100.00% <ø> (ø)
... and 18 more

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/include/parser/query/graph_pattern/rel_pattern.h Outdated Show resolved Hide resolved
src/parser/transformer.cpp Outdated Show resolved Hide resolved
@aziz-mu aziz-mu requested a review from andyfengHKU May 11, 2023 15:35
src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
src/include/planner/join_order_enumerator.h Outdated Show resolved Hide resolved
src/include/parser/query/graph_pattern/rel_pattern.h Outdated Show resolved Hide resolved
src/include/parser/query/graph_pattern/rel_pattern.h Outdated Show resolved Hide resolved
src/planner/join_order_enumerator.cpp Outdated Show resolved Hide resolved
@aziz-mu aziz-mu requested a review from andyfengHKU May 11, 2023 20:58
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to rebase to master and squash into 1 commit.

src/processor/mapper/map_extend.cpp Outdated Show resolved Hide resolved
src/planner/join_order_enumerator.cpp Outdated Show resolved Hide resolved
src/planner/join_order_enumerator.cpp Outdated Show resolved Hide resolved
@aziz-mu aziz-mu merged commit 4f75391 into master May 12, 2023
3 checks passed
@aziz-mu aziz-mu deleted the undirected-query branch May 12, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants