Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STRUCT binding for Python API #1527

Merged
merged 1 commit into from
May 10, 2023
Merged

Add STRUCT binding for Python API #1527

merged 1 commit into from
May 10, 2023

Conversation

mewim
Copy link
Collaborator

@mewim mewim commented May 10, 2023

No description provided.

@mewim mewim marked this pull request as ready for review May 10, 2023 00:55
@mewim mewim requested a review from andyfengHKU May 10, 2023 00:56
@mewim mewim force-pushed the py-struct-binding branch 2 times, most recently from 250a5a8 to b293b77 Compare May 10, 2023 00:57
andyfengHKU
andyfengHKU approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add C API. Also can u add a test of outputting struct to arrow?

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (6f72c7a) 91.93% compared to head (ba5460b) 91.96%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
+ Coverage   91.93%   91.96%   +0.02%     
==========================================
  Files         686      687       +1     
  Lines       24489    24511      +22     
==========================================
+ Hits        22515    22541      +26     
+ Misses       1974     1970       -4
Impacted Files Coverage Δ
tools/python_api/src_cpp/py_query_result.cpp 96.37% <100.00%> (+0.25%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit a669eeb into master May 10, 2023
7 checks passed
@mewim mewim deleted the py-struct-binding branch May 10, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mewim @andyfengHKU