Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support null values in list #1524

Merged
merged 1 commit into from
May 9, 2023
Merged

Support null values in list #1524

merged 1 commit into from
May 9, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented May 9, 2023

  1. Adds support to null values within a list:
    a. For valueVectors, we store the nullMasks for each value in the ListDataVector.
    b. For ku_list_t, we store the nullMasks at the start of the overflow buffer.
  2. Adds support to return an empty list:
    If a list contains no elements, the list dataType will be INT64[]

src/include/common/null_bytes.h Outdated Show resolved Hide resolved
src/function/vector_list_operation.cpp Outdated Show resolved Hide resolved
src/function/vector_list_operation.cpp Outdated Show resolved Hide resolved
src/storage/storage_structure/disk_overflow_file.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 96.42% and project coverage change: +0.01 🎉

Comparison is base (6f72c7a) 91.93% compared to head (057c219) 91.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   91.93%   91.95%   +0.01%     
==========================================
  Files         686      687       +1     
  Lines       24489    24502      +13     
==========================================
+ Hits        22515    22530      +15     
+ Misses       1974     1972       -2     
Impacted Files Coverage Δ
src/include/binder/expression_binder.h 100.00% <ø> (ø)
src/include/processor/result/factorized_table.h 90.32% <ø> (-0.16%) ⬇️
...c/storage/storage_structure/disk_overflow_file.cpp 92.44% <66.66%> (+0.53%) ⬆️
src/common/types/value.cpp 93.14% <100.00%> (+0.94%) ⬆️
src/common/vector/value_vector_utils.cpp 100.00% <100.00%> (ø)
src/function/vector_list_operation.cpp 90.90% <100.00%> (+0.35%) ⬆️
src/include/common/null_bytes.h 100.00% <100.00%> (ø)
src/processor/result/factorized_table.cpp 95.21% <100.00%> (-0.11%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin merged commit 4f02b2d into master May 9, 2023
7 checks passed
@acquamarin acquamarin deleted the list-nulls branch May 9, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants