Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert e2_read_list test to the new framework #1523

Merged
merged 1 commit into from
May 9, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented May 8, 2023

This implementation removes the use of e2e_read_list_test.cpp by using test.group files.

This implementation remove the use of e2e_read_list_test.cpp
by using test.group files.
@rfdavid rfdavid requested a review from ray6080 May 8, 2023 22:04
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6dd34cc) 91.93% compared to head (7747fbf) 91.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   91.93%   91.93%   -0.01%     
==========================================
  Files         680      685       +5     
  Lines       24543    24640      +97     
==========================================
+ Hits        22564    22652      +88     
- Misses       1979     1988       +9     

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rfdavid rfdavid merged commit 6f72c7a into kuzudb:master May 9, 2023
7 checks passed
@rfdavid rfdavid deleted the remove_e2e_read_list_test_cpp branch May 9, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants