Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove large rel list #1520

Merged
merged 1 commit into from
May 9, 2023
Merged

Remove large rel list #1520

merged 1 commit into from
May 9, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented May 8, 2023

Changes:

  • Removed large rel lists from our storage. Rel-list headers store csr offsets and length for each chunk. For example, suppose chunk 0 has 4 nodes, each node has a list of size 10, the csr offsets array stores csr offsets for node 1 to 3, and the length of the list in chunk 0. [10, 20, 30, 40]
  • Disabled add rel property with default value tests. (This needs to be fixed later after the storage changes)

This is a refactoring PR, so it's kind of messy, as I'm starting on major changes on storage very soon, I didn't clean all related code diligently for now.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 96.31% and project coverage change: -0.02 ⚠️

Comparison is base (e12c903) 91.93% compared to head (a6d49d8) 91.92%.

❗ Current head a6d49d8 differs from pull request most recent head 6f6ffbe. Consider uploading reports for the commit 6f6ffbe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   91.93%   91.92%   -0.02%     
==========================================
  Files         685      681       -4     
  Lines       24640    24393     -247     
==========================================
- Hits        22654    22424     -230     
+ Misses       1986     1969      -17     
Impacted Files Coverage Δ
src/include/catalog/catalog.h 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
...e/storage/storage_structure/lists/lists_metadata.h 92.30% <ø> (-3.70%) ⬇️
src/include/storage/store/rel_table.h 100.00% <ø> (ø)
src/include/storage/wal_replayer_utils.h 100.00% <ø> (ø)
...storage/storage_structure/lists/lists_metadata.cpp 100.00% <ø> (ø)
src/storage/store/rel_table.cpp 98.82% <ø> (+1.47%) ⬆️
src/storage/storage_utils.cpp 95.52% <50.00%> (-1.50%) ⬇️
.../storage/in_mem_storage_structure/in_mem_lists.cpp 71.87% <83.33%> (-20.57%) ⬇️
...de/storage/in_mem_storage_structure/in_mem_lists.h 84.61% <92.30%> (-10.39%) ⬇️
... and 12 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 requested a review from acquamarin May 8, 2023 04:58
@ray6080 ray6080 merged commit fa7d694 into master May 9, 2023
7 checks passed
@ray6080 ray6080 deleted the copy-rework branch May 9, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants