Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to struct of list #1518

Merged
merged 1 commit into from
May 8, 2023
Merged

Add support to struct of list #1518

merged 1 commit into from
May 8, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented May 7, 2023

This PR adds support to struct of list.

  1. When we are constructing the structValueVector, we should also create the corresponding children ValueVectors based on the children dataType.
  2. When we set the state of the structValueVector, we should also set the children state. => This guarantees that the children's vector state is always consistent with the parent's vector state.
  3. Refactors the ValueVectorUtils

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (bfc1b0d) 91.92% compared to head (0cec208) 91.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
+ Coverage   91.92%   91.93%   +0.01%     
==========================================
  Files         678      680       +2     
  Lines       24458    24543      +85     
==========================================
+ Hits        22482    22564      +82     
- Misses       1976     1979       +3     
Impacted Files Coverage Δ
src/function/vector_list_operation.cpp 90.55% <ø> (-0.11%) ⬇️
src/include/common/data_chunk/data_chunk.h 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/processor/processor_task.cpp 100.00% <ø> (ø)
src/common/data_chunk/data_chunk.cpp 100.00% <100.00%> (ø)
src/common/vector/auxiliary_buffer.cpp 100.00% <100.00%> (ø)
src/common/vector/value_vector.cpp 100.00% <100.00%> (ø)
src/common/vector/value_vector_utils.cpp 100.00% <100.00%> (ø)
src/expression_evaluator/base_evaluator.cpp 100.00% <100.00%> (ø)
src/expression_evaluator/function_evaluator.cpp 100.00% <100.00%> (ø)
... and 3 more

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/common/vector/value_vector.cpp Outdated Show resolved Hide resolved
src/common/vector/value_vector_utils.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit 6dd34cc into master May 8, 2023
7 checks passed
@acquamarin acquamarin deleted the listOfStruct branch May 8, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants