Regex String Functions #1516
Merged
Regex String Functions #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav8297
force-pushed
the
string_functions
branch
from
fbc9bec
to
d4f9833
Compare
acquamarin
requested changes
May 6, 2023
There was a problem hiding this comment.
Good start!
- Our CI uses the clang-format tool to check the formatting of our code. You can get a copy of the format checking script here: https://github.com/Sarcasm/run-clang-format/blob/master/run-clang-format.py. Be sure to check the formatting of your code using this tool before pushing.
- Please make sure that your code can pass all the CI before submitting.
- We prefer to squash all commits into one for each PR.
If you have any questions related to my comments, feel free to message me.
gaurav8297
force-pushed
the
string_functions
branch
4 times, most recently
from
13ace76
to
9e3b399
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
+ Coverage 91.91% 91.93% +0.02%
==========================================
Files 678 685 +7
Lines 24458 24640 +182
==========================================
+ Hits 22480 22653 +173
- Misses 1978 1987 +9
☔ View full report in Codecov by Sentry. |
acquamarin
reviewed
May 6, 2023
src/include/function/string/operations/regexp_extract_all_operation.h
Outdated
Show resolved
Hide resolved
gaurav8297
force-pushed
the
string_functions
branch
from
9e3b399
to
395fb82
Compare
acquamarin
approved these changes
May 8, 2023
src/include/function/string/operations/regexp_extract_all_operation.h
Outdated
Show resolved
Hide resolved
src/include/function/string/operations/regexp_extract_all_operation.h
Outdated
Show resolved
Hide resolved
src/include/function/string/operations/regexp_extract_all_operation.h
Outdated
Show resolved
Hide resolved
src/include/function/string/operations/regexp_extract_all_operation.h
Outdated
Show resolved
Hide resolved
src/include/function/string/operations/regexp_extract_operation.h
Outdated
Show resolved
Hide resolved
acquamarin
approved these changes
May 8, 2023
Rename RE_MATCH function to REGEXP_FULL_MATCH The latter is more descriptive and complaint with duckdb's naming convention. Introduce regexp utils based on re2 Refactor regex_full_match implementation Functions added: 1.regexp_matches(string, regex) Returns true if a part of string matches the regex. 2. regexp_replace(string, regex, replacement) Replaces the first occurrence of regex with the replacement, 3. regexp_extract(string, regex[, group = 0]) Split the string along the regex and extract first occurrence of group. 4. regexp_extract_all(string, regex[, group = 0]) Split the string along the regex and extract all occurrences of group.
gaurav8297
force-pushed
the
string_functions
branch
from
395fb82
to
a682d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions added:
regexp_matches(string, regex)
Returns true if a part of string matches the regex.
regexp_replace(string, regex, replacement)
Replaces the first occurrence of regex with the replacement,
regexp_extract(string, regex[, group = 0])
Split the string along the regex and extract first occurrence of group.
regexp_extract_all(string, regex[, group = 0])
Split the string along the regex and extract all occurrences of group.
I have read and agree to the terms under CLA.md