Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vlq rework #1505

Merged
merged 1 commit into from
May 3, 2023
Merged

Vlq rework #1505

merged 1 commit into from
May 3, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR changes variable length join evaluation strategy from DFS to BFS and unify with shortest path join

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 94.48% and project coverage change: -0.08 ⚠️

Comparison is base (ecb5d46) 92.30% compared to head (2a7b455) 92.22%.

❗ Current head 2a7b455 differs from pull request most recent head 7280162. Consider uploading reports for the commit 7280162 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
- Coverage   92.30%   92.22%   -0.08%     
==========================================
  Files         678      676       -2     
  Lines       24350    24306      -44     
==========================================
- Hits        22476    22417      -59     
- Misses       1874     1889      +15     
Impacted Files Coverage Δ
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
src/processor/mapper/map_semi_masker.cpp 92.00% <ø> (ø)
...essor/operator/recursive_extend/recursive_join.cpp 78.00% <78.00%> (ø)
src/processor/mapper/map_extend.cpp 97.56% <92.85%> (+2.38%) ⬆️
.../processor/operator/recursive_extend/bfs_state.cpp 94.73% <94.73%> (ø)
...l_plan/logical_operator/logical_recursive_extend.h 100.00% <100.00%> (ø)
src/include/processor/operator/mask.h 100.00% <100.00%> (ø)
...de/processor/operator/recursive_extend/bfs_state.h 100.00% <100.00%> (ø)
...ocessor/operator/recursive_extend/recursive_join.h 100.00% <100.00%> (ø)
...or/recursive_extend/shortest_path_recursive_join.h 100.00% <100.00%> (ø)
... and 5 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 4eebacf into master May 3, 2023
7 checks passed
@andyfengHKU andyfengHKU deleted the vlq-rework branch May 3, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants