Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sink before recursive join #1500

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Add sink before recursive join #1500

merged 1 commit into from
Apr 27, 2023

Conversation

andyfengHKU
Copy link
Contributor

This is to achieve better granularity for SSP computation. This sink is also needed for a different parallelism strategy where multiple threads can work on a single source.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d9695fd) 92.27% compared to head (ddfdcde) 92.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         675      675           
  Lines       24264    24275   +11     
=======================================
+ Hits        22389    22400   +11     
  Misses       1875     1875           
Impacted Files Coverage Δ
...cessor/operator/var_length_extend/recursive_join.h 100.00% <100.00%> (ø)
src/planner/join_order/cardinality_estimator.cpp 96.55% <100.00%> (-0.06%) ⬇️
src/planner/operator/logical_recursive_extend.cpp 100.00% <100.00%> (ø)
src/processor/mapper/map_extend.cpp 95.23% <100.00%> (+0.36%) ⬆️
...ssor/operator/var_length_extend/recursive_join.cpp 98.61% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 4e5f17d into master Apr 27, 2023
@andyfengHKU andyfengHKU deleted the ssp-sink branch April 27, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants