Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate templatizing of HashIndexBuilder inside PrimaryKeyIndexBuilder #1491

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Apr 25, 2023

This is a rework to get rid of lots of template functions due to the templatizing of HashIndexBuilder. Similar to PrimaryKeyIndex, this PR moves the templatizing logic inside PrimaryKeyIndexBuilder.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 87.59% and no project coverage change.

Comparison is base (ae34410) 92.07% compared to head (db49f79) 92.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1491   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         671      671           
  Lines       23855    23894   +39     
=======================================
+ Hits        21965    22001   +36     
- Misses       1890     1893    +3     
Impacted Files Coverage Δ
src/include/storage/copier/node_copy_executor.h 100.00% <ø> (ø)
src/storage/copier/table_copy_executor.cpp 86.89% <0.00%> (ø)
src/include/storage/index/hash_index_builder.h 83.01% <85.29%> (+4.07%) ⬆️
src/include/storage/copier/node_copier.h 92.15% <93.75%> (+0.32%) ⬆️
src/storage/copier/node_copier.cpp 93.05% <96.22%> (-0.47%) ⬇️
src/include/common/exception.h 87.50% <100.00%> (+4.89%) ⬆️
...age/in_mem_storage_structure/in_mem_column_chunk.h 100.00% <100.00%> (ø)
src/storage/copier/node_copy_executor.cpp 92.98% <100.00%> (+2.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit 14e1277 into master Apr 26, 2023
@ray6080 ray6080 deleted the copy-rework branch April 26, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants