Add loader and storage support for struct #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
force-pushed
the
struct-storage
branch
from
3386624
to
cc7ed5e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 92.07% 92.20% +0.13%
==========================================
Files 671 671
Lines 23894 24069 +175
==========================================
+ Hits 22001 22194 +193
+ Misses 1893 1875 -18
☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Apr 26, 2023
| template<> | ||
| void InMemColumnChunk::setValueFromString<bool>( | ||
| const char* value, uint64_t length, common::page_idx_t pageIdx, uint64_t posInPage) { | ||
| std::istringstream boolStream{std::string(value)}; |
There was a problem hiding this comment.
Ditto. Can we not use istringstream here?
acquamarin
force-pushed
the
struct-storage
branch
from
cc7ed5e
to
14bf9c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic loader and storage support for struct dataType.
Unresolved struct dataType issues:
Match (m:movies) return m.description.ratingexception bug.