Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSP pipeline #1489

Merged
merged 1 commit into from
Apr 27, 2023
Merged

SSP pipeline #1489

merged 1 commit into from
Apr 27, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR implements the non-blocking version of shortest path.

In the front end, SHORTEST_PATH edge is treated in the same way as a regular query edge except that we don't allow property reading on SHORTEST_PATH edge.

In the back end, we add a RecursiveJoin operator that computes the SHORTEST_PATH for a single src node. Parallelism is achieved by having different threads working on different source node. Note this approach will suffer from skewness.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 96.68% and project coverage change: -0.08 ⚠️

Comparison is base (247cf1b) 92.20% compared to head (9a63709) 92.13%.

❗ Current head 9a63709 differs from pull request most recent head dbfd1fa. Consider uploading reports for the commit dbfd1fa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
- Coverage   92.20%   92.13%   -0.08%     
==========================================
  Files         671      675       +4     
  Lines       24069    24018      -51     
==========================================
- Hits        22194    22130      -64     
- Misses       1875     1888      +13     
Impacted Files Coverage Δ
src/include/binder/expression_binder.h 100.00% <ø> (ø)
src/include/processor/operator/physical_operator.h 100.00% <ø> (ø)
src/include/processor/operator/result_collector.h 100.00% <ø> (ø)
src/processor/operator/physical_operator.cpp 91.26% <50.00%> (+0.08%) ⬆️
src/processor/mapper/map_extend.cpp 94.87% <85.18%> (-5.13%) ⬇️
...processor/operator/var_length_extend/bfs_state.cpp 97.95% <97.95%> (ø)
src/binder/bind/bind_graph_pattern.cpp 94.32% <100.00%> (+0.08%) ⬆️
...inder/bind_expression/bind_function_expression.cpp 98.42% <100.00%> (+0.07%) ⬆️
...inder/bind_expression/bind_property_expression.cpp 91.30% <100.00%> (+0.19%) ⬆️
src/include/binder/expression/rel_expression.h 100.00% <100.00%> (ø)
... and 6 more

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 self-requested a review April 25, 2023 21:36
src/include/common/constants.h Show resolved Hide resolved
src/processor/operator/var_length_extend/bfs_state.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 7547c8e into master Apr 27, 2023
@andyfengHKU andyfengHKU deleted the ssp-pipeline branch April 27, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants