Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PropertyNameDataType #1488

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Remove PropertyNameDataType #1488

merged 1 commit into from
Apr 25, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Apr 25, 2023

This PR simplifies class hierarchy for Property a bit by removing the base class PropertyNameDataType.

src/catalog/catalog.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (09106ce) 92.08% compared to head (3aef2e0) 92.07%.

❗ Current head 3aef2e0 differs from pull request most recent head ae34410. Consider uploading reports for the commit ae34410 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
- Coverage   92.08%   92.07%   -0.01%     
==========================================
  Files         671      671              
  Lines       23864    23855       -9     
==========================================
- Hits        21974    21965       -9     
  Misses       1890     1890              
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/catalog/catalog.h 100.00% <ø> (ø)
src/include/processor/operator/order_by/order_by.h 100.00% <ø> (ø)
src/include/storage/index/hash_index.h 94.11% <ø> (-0.17%) ⬇️
src/binder/bind/bind_copy.cpp 76.74% <100.00%> (ø)
src/binder/bind/bind_ddl.cpp 100.00% <100.00%> (ø)
src/binder/binder.cpp 96.26% <100.00%> (ø)
src/catalog/catalog.cpp 89.38% <100.00%> (+0.04%) ⬆️
src/include/binder/ddl/bound_create_node_clause.h 100.00% <100.00%> (ø)
src/include/binder/ddl/bound_create_rel_clause.h 100.00% <100.00%> (ø)
... and 11 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit 5421c64 into master Apr 25, 2023
@ray6080 ray6080 deleted the copy-rework branch April 25, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants