Add c, cpp examples #1485
Add c, cpp examples #1485
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
==========================================
- Coverage 92.12% 92.07% -0.06%
==========================================
Files 671 671
Lines 23831 23846 +15
==========================================
+ Hits 21955 21956 +1
- Misses 1876 1890 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -54,8 +54,8 @@ TEST_F(CApiFlatTupleTest, ToString) { | |||
| columnWidths[0] = 10; | |||
| columnWidths[1] = 5; | |||
| columnWidths[2] = 10; | |||
| auto str = kuzu_flat_tuple_to_string(flatTuple, columnWidths, 3, "\t", 1024); | |||
| ASSERT_EQ(std::string(str), " Alice \t 35 \t 1.731000 "); | |||
| auto str = kuzu_flat_tuple_to_string(flatTuple); | |||
There was a problem hiding this comment.
Since the function no longer requires passing a columnWidths array. It should also be removed from this test case.
There was a problem hiding this comment.
This test is meant to replace the original to_string API with a new one that doesn't require columnWidths. to_string() is still needed.
There was a problem hiding this comment.
I mean that the lines:
auto columnWidths = (uint32_t*)malloc(3 * sizeof(uint32_t));
columnWidths[0] = 10;
columnWidths[1] = 5;
columnWidths[2] = 10;
and
free(columnWidths);
should be removed as the function is no longer called with columnWidths.
No description provided.