Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct planning #1479

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Struct planning #1479

merged 1 commit into from
Apr 22, 2023

Conversation

andyfengHKU
Copy link
Contributor

  • Add struct_extract function
  • Bind struct.prop as struct_extract function
  • Introduce FunctionBindData to holds function binding information
    • Always contains result type (in case need to resolve recursive result type e.g. list_extract)
    • For struct_extract functions, it further resolves string property access as idx access.
  • Resolve struct_pack and struct_extract at compile time

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: +92.12 🎉

Comparison is base (3e04497) 0.00% compared to head (d1dc6c3) 92.12%.

❗ Current head d1dc6c3 differs from pull request most recent head 4ce7aa9. Consider uploading reports for the commit 4ce7aa9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1479       +/-   ##
===========================================
+ Coverage        0   92.12%   +92.12%     
===========================================
  Files           0      671      +671     
  Lines           0    23835    +23835     
===========================================
+ Hits            0    21958    +21958     
- Misses          0     1877     +1877     
Impacted Files Coverage Δ
src/include/binder/expression_binder.h 100.00% <ø> (ø)
src/include/common/types/types.h 81.81% <ø> (ø)
src/include/function/list/vector_list_operations.h 97.36% <ø> (ø)
src/include/processor/processor_task.h 100.00% <ø> (ø)
src/function/vector_list_operation.cpp 90.86% <82.92%> (ø)
src/function/vector_struct_operations.cpp 86.66% <88.88%> (ø)
...binder/bind_expression/bind_boolean_expression.cpp 100.00% <100.00%> (ø)
...der/bind_expression/bind_comparison_expression.cpp 100.00% <100.00%> (ø)
...inder/bind_expression/bind_function_expression.cpp 98.34% <100.00%> (ø)
.../bind_expression/bind_null_operator_expression.cpp 100.00% <100.00%> (ø)
... and 10 more

... and 651 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/processor/processor_task.cpp Show resolved Hide resolved
test/binder/binder_error_test.cpp Show resolved Hide resolved
src/processor/processor_task.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit f0d768e into master Apr 22, 2023
@andyfengHKU andyfengHKU deleted the struct-planning branch April 22, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants