Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortest Path changes #1468

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Shortest Path changes #1468

merged 1 commit into from
Apr 19, 2023

Conversation

anuchak
Copy link
Collaborator

@anuchak anuchak commented Apr 16, 2023

This PR has all the current changes of Shortest Path including frontend and physical operators.

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.04 ⚠️

Comparison is base (35b02b6) 91.84% compared to head (7ba7945) 91.80%.

❗ Current head 7ba7945 differs from pull request most recent head 97bcf9e. Consider uploading reports for the commit 97bcf9e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
- Coverage   91.84%   91.80%   -0.04%     
==========================================
  Files         661      657       -4     
  Lines       23140    23012     -128     
==========================================
- Hits        21252    21126     -126     
+ Misses       1888     1886       -2     
Impacted Files Coverage Δ
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/include/processor/operator/physical_operator.h 100.00% <ø> (ø)
src/processor/operator/physical_operator.cpp 91.17% <0.00%> (-1.83%) ⬇️
src/common/types/types.cpp 79.61% <100.00%> (ø)

... and 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anuchak anuchak marked this pull request as ready for review April 16, 2023 03:57
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge the physical operator part and well the test suite. So can u do the following

  • Remove code that is not under processor/
  • Describe how you generated the test dataset, i.e. what are connectivity pattern.

To pass CI you will need to comment out test code as well.

@anuchak
Copy link
Collaborator Author

anuchak commented Apr 18, 2023

All front end related changes for shortest path have been removed.

@anuchak anuchak merged commit 8a8c8c9 into master Apr 19, 2023
@anuchak anuchak deleted the shortestpath branch April 19, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants