Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework hashjoin #1465

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Rework hashjoin #1465

merged 1 commit into from
Apr 14, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR separates HJ implementation into 2 cases

  • we probe for a batch if we know each key has at most one match
  • we probe one tuple at a time and also ship one tuple at a time in the general case

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 94.52% and project coverage change: +0.79 🎉

Comparison is base (e83ee32) 91.82% compared to head (a05333c) 92.62%.

❗ Current head a05333c differs from pull request most recent head cffe67e. Consider uploading reports for the commit cffe67e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
+ Coverage   91.82%   92.62%   +0.79%     
==========================================
  Files         655      655              
  Lines       22921    22935      +14     
==========================================
+ Hits        21047    21243     +196     
+ Misses       1874     1692     -182     
Impacted Files Coverage Δ
.../logical_plan/logical_operator/logical_hash_join.h 100.00% <ø> (ø)
...c/processor/operator/hash_join/hash_join_probe.cpp 93.45% <93.22%> (-0.16%) ⬇️
...ude/processor/operator/hash_join/hash_join_probe.h 100.00% <100.00%> (ø)
src/processor/mapper/map_hash_join.cpp 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU changed the title Rewrok hashjoin Rework hashjoin Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants