Add struct literal support #1462
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
- Coverage 92.16% 92.14% -0.03%
==========================================
Files 669 670 +1
Lines 23676 23806 +130
==========================================
+ Hits 21821 21936 +115
- Misses 1855 1870 +15
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| std::make_unique<ParsedFunctionExpression>(common::STRUCT_PACK_FUNC_NAME, ctx.getText()); | ||
| for (auto& structField : ctx.oC_StructField()) { | ||
| auto structExpr = transformExpression(*structField->oC_Expression()); | ||
| structExpr->setAlias(transformSymbolicName(*structField->oC_SymbolicName())); |
There was a problem hiding this comment.
We probably need to discuss how to access a field from a struct. That part is currently missing and might be tricky to do.
| copyNonNullDataWithSameType(resultVector.dataType, srcData, | ||
| resultVector.getData() + pos * resultVector.getNumBytesPerValue(), | ||
| resultVector.getOverflowBuffer()); | ||
| if (resultVector.dataType.typeID == STRUCT) { |
There was a problem hiding this comment.
now that you are changing this. I think we should discuss how LIST can be done in a similar fashion. ideally this copyInto and copyFrom should be handled with
switch typeID
recursive types:
...
non recursive types:
...
@ray6080 should think about this as well.
acquamarin
force-pushed
the
struct-processing
branch
from
5c7b119
to
bdf82f5
Compare
acquamarin
force-pushed
the
struct-processing
branch
from
bdf82f5
to
8dc4439
Compare
Add struct literal support.
Example: return {weight: 5, height: 20}will return a struct with '{weight: 5, height: 20}'