Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify column types in csv reader and remove arrow status return value from functions #1461

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Apr 12, 2023

No description provided.

@ray6080 ray6080 force-pushed the copy-rework branch 2 times, most recently from f0df25b to f2264ff Compare April 12, 2023 18:14
@ray6080 ray6080 marked this pull request as ready for review April 12, 2023 22:19
@ray6080 ray6080 force-pushed the copy-rework branch 3 times, most recently from 93220f5 to 742c00d Compare April 12, 2023 23:41
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 92.72% and project coverage change: -0.79 ⚠️

Comparison is base (b001e03) 92.61% compared to head (0d1e363) 91.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1461      +/-   ##
==========================================
- Coverage   92.61%   91.82%   -0.79%     
==========================================
  Files         655      655              
  Lines       22914    22921       +7     
==========================================
- Hits        21221    21048     -173     
- Misses       1693     1873     +180     
Impacted Files Coverage Δ
src/storage/copier/rel_copier.cpp 94.62% <82.35%> (-0.97%) ⬇️
src/storage/copier/table_copier.cpp 85.71% <92.53%> (-0.46%) ⬇️
src/include/catalog/catalog_structs.h 98.27% <100.00%> (+0.03%) ⬆️
src/include/storage/copier/node_copier.h 100.00% <100.00%> (ø)
src/include/storage/copier/table_copier.h 100.00% <100.00%> (ø)
src/storage/copier/node_copier.cpp 90.57% <100.00%> (-0.93%) ⬇️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit f9a7c89 into master Apr 13, 2023
@ray6080 ray6080 deleted the copy-rework branch April 13, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants