-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add struct data type front end #1457
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
- Coverage 92.67% 92.59% -0.09%
==========================================
Files 655 655
Lines 22817 22900 +83
==========================================
+ Hits 21146 21204 +58
- Misses 1671 1696 +25
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
return typeID == other.typeID; | ||
switch (other.typeID) { | ||
case VAR_LIST: | ||
return *reinterpret_cast<VarListTypeInfo*>(extraTypeInfo.get()) == |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remind us to discuss the casting code style.
I always do (Type*) instead of reinterpret_cast<Type*> in the front end.
STRUCT
data type. Grammar forSTRUCT
type is: STRUCT(prop1 prop1Type, prop2 prop2Type).propertyIdx
->propertyID
.