Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct data type front end #1457

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Add struct data type front end #1457

merged 1 commit into from
Apr 10, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Apr 9, 2023

  1. Implement front end for STRUCT data type. Grammar for STRUCT type is: STRUCT(prop1 prop1Type, prop2 prop2Type).
  2. Renames propertyIdx -> propertyID.
  3. Refactors how dataType stores extraTypeInfo.

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Patch coverage: 83.61% and project coverage change: -0.09 ⚠️

Comparison is base (c344c83) 92.67% compared to head (30fbde8) 92.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
- Coverage   92.67%   92.59%   -0.09%     
==========================================
  Files         655      655              
  Lines       22817    22900      +83     
==========================================
+ Hits        21146    21204      +58     
- Misses       1671     1696      +25     
Impacted Files Coverage Δ
src/catalog/catalog.cpp 89.34% <ø> (-0.50%) ⬇️
src/include/catalog/catalog_structs.h 98.24% <ø> (ø)
src/include/common/ser_deser.h 100.00% <ø> (ø)
src/include/storage/copier/npy_node_copier.h 100.00% <ø> (ø)
src/include/storage/store/rel_table.h 100.00% <ø> (ø)
...storage/in_mem_storage_structure/in_mem_column.cpp 94.91% <ø> (ø)
.../storage/in_mem_storage_structure/in_mem_lists.cpp 96.63% <ø> (ø)
src/storage/copier/table_copier.cpp 82.23% <62.50%> (+0.18%) ⬆️
src/common/types/types.cpp 79.61% <71.21%> (-3.72%) ⬇️
src/include/common/types/types.h 75.00% <71.42%> (-25.00%) ⬇️
... and 28 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/copy/copy_npy_test.cpp Outdated Show resolved Hide resolved
src/common/types/types.cpp Outdated Show resolved Hide resolved
src/common/types/types.cpp Outdated Show resolved Hide resolved
return typeID == other.typeID;
switch (other.typeID) {
case VAR_LIST:
return *reinterpret_cast<VarListTypeInfo*>(extraTypeInfo.get()) ==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remind us to discuss the casting code style.

I always do (Type*) instead of reinterpret_cast<Type*> in the front end.

src/storage/copier/rel_copier.cpp Show resolved Hide resolved
test/binder/binder_error_test.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit 06181ac into master Apr 10, 2023
@acquamarin acquamarin deleted the struct-type branch April 10, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants