Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bm file handle remove pages in eviction queue #1431

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix bm file handle remove pages in eviction queue #1431

merged 1 commit into from
Apr 3, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Mar 31, 2023

No description provided.

@ray6080 ray6080 force-pushed the bm-fix branch 3 times, most recently from 00c32cc to 267ab5f Compare April 2, 2023 21:26
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: -0.06 ⚠️

Comparison is base (c85bb1c) 92.71% compared to head (cb22a59) 92.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
- Coverage   92.71%   92.65%   -0.06%     
==========================================
  Files         652      652              
  Lines       22791    22816      +25     
==========================================
+ Hits        21130    21140      +10     
- Misses       1661     1676      +15     
Impacted Files Coverage Δ
...rc/include/storage/buffer_manager/bm_file_handle.h 100.00% <ø> (ø)
src/include/processor/operator/copy/copy_rel.h 62.50% <33.33%> (ø)
...rc/include/storage/buffer_manager/buffer_manager.h 76.00% <45.45%> (-17.34%) ⬇️
src/storage/buffer_manager/buffer_manager.cpp 81.57% <92.85%> (-0.43%) ⬇️
src/processor/mapper/map_ddl.cpp 100.00% <100.00%> (ø)
src/processor/operator/copy/copy_rel.cpp 100.00% <100.00%> (ø)
src/storage/buffer_manager/bm_file_handle.cpp 98.85% <100.00%> (+0.04%) ⬆️
src/storage/copier/rel_copier.cpp 95.59% <100.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 marked this pull request as ready for review April 3, 2023 00:33
@ray6080 ray6080 merged commit 0fe05bd into master Apr 3, 2023
@ray6080 ray6080 deleted the bm-fix branch April 3, 2023 05:38
@andyfengHKU andyfengHKU mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants