Fix copy invalid filepath #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1426 +/- ##
==========================================
- Coverage 92.64% 92.64% -0.01%
==========================================
Files 650 650
Lines 22544 22547 +3
==========================================
+ Hits 20886 20888 +2
- Misses 1658 1659 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Mar 30, 2023
| @@ -40,6 +40,10 @@ std::vector<std::string> Binder::bindFilePaths(const std::vector<std::string>& f | |||
| std::vector<std::string> boundFilePaths; | |||
| for (auto& filePath : filePaths) { | |||
| auto globbedFilePaths = FileUtils::globFilePath(filePath); | |||
| if (globbedFilePaths.empty()) { | |||
| throw BinderException{StringUtils::string_format( | |||
| "No file found that matches the pattern: {}.", filePath)}; | |||
There was a problem hiding this comment.
I guess the common error msg should be file path not exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying files to node/rel tables, if the given filepath is invalid we should throw an exception.