Optimize copy node memory usage #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
force-pushed
the
low-mem-copy-os-allocate
branch
from
1e92fd3
to
19176d0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 92.64% 92.66% +0.01%
==========================================
Files 649 651 +2
Lines 22382 22507 +125
==========================================
+ Hits 20735 20855 +120
- Misses 1647 1652 +5
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
andyfengHKU
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming
Unifies copy related class names to
TableCopier,NodeCopier,NpyNodeCopierandRelCopier.Optimize memory usage
When copy node tables, we no longer prepare all pages needed by in memory columns, which can easily cause OOM when the node table is quite large, and increase memory pressure of the machine.
Instead, each task will dynamically allocate a InMemColumnChunk, which contains a set of pages as needed. When the task has finished writing and flushing pages to disk, the task releases the column chunk, which can greatly reduce memory occupation.