Populate by column #1424
Merged
Populate by column #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 651 650 -1
Lines 22557 22544 -13
=======================================
- Hits 20897 20886 -11
+ Misses 1660 1658 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ray6080
force-pushed
the
copy-by-column
branch
2 times, most recently
from
66598b8
to
6be982e
Compare
ray6080
approved these changes
Mar 29, 2023
ray6080
reviewed
Mar 29, 2023
src/storage/copier/node_copier.cpp
Outdated
| CopyDescription& copyDescription, PageByteCursor& overflowCursor) { | ||
| for (auto i = 0u; i < numLinesInCurBlock; i++) { | ||
| auto nodeOffset = startNodeOffset + i; | ||
| auto currentToken = arrowArray->GetScalar(i); | ||
| if ((*currentToken)->is_valid) { | ||
| auto stringToken = currentToken->get()->ToString(); | ||
| const char* data = stringToken.c_str(); | ||
| switch (column->getDataType().typeID) { |
There was a problem hiding this comment.
I would move the switch case out of the for loop.
acquamarin
force-pushed
the
copy-by-column
branch
from
6be982e
to
cb453ea
Compare
acquamarin
force-pushed
the
copy-by-column
branch
from
cb453ea
to
7e0368c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logic of populating inMemColumn while loading a node table. Instead of populating a row at a time, we populate a column at a time.