Remote backend for PyG #1418
Merged
Remote backend for PyG #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mewim
force-pushed
the
pyg-remote-backend
branch
from
7caff52
to
fbd7071
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
+ Coverage 92.64% 92.72% +0.07%
==========================================
Files 650 651 +1
Lines 22613 22749 +136
==========================================
+ Hits 20949 21093 +144
+ Misses 1664 1656 -8
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mewim
force-pushed
the
pyg-remote-backend
branch
3 times, most recently
from
52bd939
to
8c098f6
Compare
ray6080
reviewed
Mar 29, 2023
src/include/main/storage_driver.h
Outdated
|
|
||
| ~StorageDriver(); | ||
|
|
||
| std::pair<std::unique_ptr<uint8_t[]>, size_t> scan(const std::string& nodeName, |
There was a problem hiding this comment.
I would wrap the pair into a struct:
struct Buffer {
std::unique_ptr<uint8_t> data;
std::size_t size;
}
| auto frame = bufferManager.pin(*fileHandleToPin, pageIdxToPin); | ||
| auto frameBytesOffset = getElemByteOffset(cursor.elemPosInPage); | ||
| memcpy(result + i * elementSize, frame + frameBytesOffset, elementSize); | ||
| bufferManager.unpin(*fileHandleToPin, pageIdxToPin); |
There was a problem hiding this comment.
L19 - L22 :
bufferManager.optimisticRead(*fileHandleToPin, pageIdxToPin, [&](uint8_t* frame) -> void {
auto frameBytesOffset = getElemByteOffset(cursor.elemPosInPage);
memcpy(result + i * elementSize, frame + frameBytesOffset, elementSize);
});
0f22317
to
19b5e0a
Compare
mewim
force-pushed
the
pyg-remote-backend
branch
from
19b5e0a
to
6ee6705
Compare
andyfengHKU
approved these changes
Apr 2, 2023
| std::unordered_map<std::string, std::shared_ptr<Value>> parameters; | ||
| parameters["s"] = std::make_shared<Value>(start); | ||
| parameters["e"] = std::make_shared<Value>(end); | ||
| std::cout << "Batch " << batch << " from " << start << " to " << end << std::endl; |
There was a problem hiding this comment.
Maybe we should remove before the final release. But let's keep it for benchmark purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.