Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework asp optimizer #1417

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Rework asp optimizer #1417

merged 1 commit into from
Mar 29, 2023

Conversation

andyfengHKU
Copy link
Contributor

  • rename ASP to AccHashJoin
  • disable SIP from probe to build when probe is much greater than build
  • enable SIP from build to probe when probe is much greater than build
  • optimize enumeration to avoid generating hash join whose cost is already known to be greater than the max cost for a given subgraph

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 93.68% and project coverage change: -0.02 ⚠️

Comparison is base (8f34ab1) 92.64% compared to head (1710491) 92.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
- Coverage   92.64%   92.62%   -0.02%     
==========================================
  Files         649      649              
  Lines       22382    22432      +50     
==========================================
+ Hits        20735    20777      +42     
- Misses       1647     1655       +8     
Impacted Files Coverage Δ
src/common/copier_config/copier_config.cpp 88.88% <0.00%> (-11.12%) ⬇️
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/include/optimizer/logical_operator_visitor.h 92.42% <33.33%> (-2.82%) ⬇️
src/optimizer/logical_operator_visitor.cpp 95.61% <60.00%> (-1.64%) ⬇️
src/include/optimizer/acc_hash_join_optimizer.h 100.00% <100.00%> (ø)
src/include/optimizer/logical_operator_collector.h 90.00% <100.00%> (+2.50%) ⬆️
src/include/planner/subplans_table.h 100.00% <100.00%> (ø)
src/optimizer/acc_hash_join_optimizer.cpp 100.00% <100.00%> (ø)
src/optimizer/optimizer.cpp 100.00% <100.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/include/common/constants.h Outdated Show resolved Hide resolved
src/processor/mapper/map_hash_join.cpp Show resolved Hide resolved
src/optimizer/acc_hash_join_optimizer.cpp Show resolved Hide resolved
src/include/optimizer/acc_hash_join_optimizer.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants