Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min/max agg function support for more types #1410

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

acquamarin
Copy link
Collaborator

Fix issue #1407.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (4dc00f0) 92.65% compared to head (ccba576) 92.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
+ Coverage   92.65%   92.71%   +0.05%     
==========================================
  Files         642      642              
  Lines       22109    22115       +6     
==========================================
+ Hits        20485    20503      +18     
+ Misses       1624     1612      -12     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/common/types/types.cpp 82.68% <100.00%> (+0.19%) ⬆️
src/function/aggregate_function.cpp 84.84% <100.00%> (+10.65%) ⬆️
src/function/built_in_aggregate_functions.cpp 94.62% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin merged commit 73f3f91 into master Mar 25, 2023
@acquamarin acquamarin deleted the agg-func branch March 25, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants