Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode plan when inserting to dp table #1406

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

andyfengHKU
Copy link
Contributor

This PR removes the custom hasher for schema because they are not computational efficient. Instead, we now encode a logical plan's factorization schema into a bitset by considering the flat information of certain expressions. As a consequence

  • We improve the computational time of enumeration.
  • We reduce the number of plans kept in each subgraph.
  • Fewer plans are being generated.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08 ⚠️

Comparison is base (3345cb3) 92.73% compared to head (11910ae) 92.66%.

❗ Current head 11910ae differs from pull request most recent head 90f0f0d. Consider uploading reports for the commit 90f0f0d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
- Coverage   92.73%   92.66%   -0.08%     
==========================================
  Files         642      642              
  Lines       22110    22089      -21     
==========================================
- Hits        20504    20468      -36     
- Misses       1606     1621      +15     
Impacted Files Coverage Δ
src/binder/query/query_graph.cpp 96.29% <ø> (ø)
.../include/binder/query/reading_clause/query_graph.h 96.66% <ø> (ø)
...ude/planner/logical_plan/logical_operator/schema.h 100.00% <ø> (ø)
src/planner/operator/schema.cpp 70.00% <ø> (-8.73%) ⬇️
src/include/planner/subplans_table.h 100.00% <100.00%> (ø)
src/planner/join_order_enumerator.cpp 98.36% <100.00%> (+<0.01%) ⬆️
src/planner/subplans_table.cpp 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/include/planner/subplans_table.h Show resolved Hide resolved
src/include/planner/subplans_table.h Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 4dc00f0 into master Mar 24, 2023
@andyfengHKU andyfengHKU deleted the reduce-dp-level-size branch March 24, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants