-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query timeout mechanism #1395
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
=======================================
Coverage 92.79% 92.80%
=======================================
Files 641 642 +1
Lines 22043 22066 +23
=======================================
+ Hits 20455 20478 +23
Misses 1588 1588
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update your pr description (timeout is not applicable to Copy). And I want to take another look, meanwhile we can discuss how to address the problem of propagate the exception in one worker thread to others in the same task.
37c8a49
to
c1024ad
Compare
1. Query timeout mechanism:
a. The system will abort queries which execute longer than the time_out limit.
b. The default timeout value is 120000MS(2 minutes) and query timeout is disabled by default.
2. Added two APIs to connection:
a.
void setQueryTimeOut(uint64_t timeoutInMS)
: sets the query timeout value of the current connection.b.
void setQueryTimeOutEnabled(bool isEnabled)
: enables/disabled the query timeout of the current connection.