-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorization aware dp #1384
Factorization aware dp #1384
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 92.76% 92.78% +0.02%
==========================================
Files 641 641
Lines 22005 22085 +80
==========================================
+ Hits 20412 20492 +80
Misses 1593 1593
... and 27 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
38abd23
to
3a06d27
Compare
This PR changes the set of plans that kept in DP table during enumeration. Previous, we only keep plans with top K (K=50) lowest cost. This PR keeps plans with top 1 lowest cost for each different factorization structure.
The rationale is
This PR also fixes issue #1098 and #1371