Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi scans asp #1375

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Multi scans asp #1375

merged 1 commit into from
Mar 15, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR enables pushing one semi mask to multiple ScanNodeID operators.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 97.91% and no project coverage change.

Comparison is base (e3961e6) 92.76% compared to head (01aa911) 92.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1375   +/-   ##
=======================================
  Coverage   92.76%   92.77%           
=======================================
  Files         641      641           
  Lines       22077    22085    +8     
=======================================
+ Hits        20480    20489    +9     
+ Misses       1597     1596    -1     
Impacted Files Coverage Δ
src/include/optimizer/asp_optimizer.h 100.00% <ø> (ø)
...ogical_plan/logical_operator/logical_semi_masker.h 81.81% <87.50%> (+4.04%) ⬆️
src/include/processor/operator/semi_masker.h 100.00% <100.00%> (ø)
src/optimizer/asp_optimizer.cpp 100.00% <100.00%> (ø)
src/processor/mapper/map_asp.cpp 100.00% <100.00%> (ø)
src/processor/operator/semi_masker.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit f06fdca into master Mar 15, 2023
@andyfengHKU andyfengHKU deleted the multi-scans-asp branch March 15, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants