Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change databasePath to positional argument #1350

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Change databasePath to positional argument #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion third_party/spdlog/spdlog/fmt/bundled/core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,7 +1467,7 @@ template <typename Context> struct arg_mapper {
std::is_enum<T>::value&& std::is_convertible<T, int>::value &&
!has_format_as<T>::value && !has_formatter<T, Context>::value &&
!has_fallback_formatter<T, char_type>::value)>
FMT_DEPRECATED FMT_CONSTEXPR FMT_INLINE auto map(const T& val)
FMT_CONSTEXPR FMT_INLINE auto map(const T& val)
-> decltype(std::declval<arg_mapper>().map(
static_cast<underlying_t<T>>(val))) {
return map(static_cast<underlying_t<T>>(val));
Expand Down
4 changes: 2 additions & 2 deletions tools/shell/shell_runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ using namespace kuzu::main;

int main(int argc, char* argv[]) {
args::ArgumentParser parser("KuzuDB Shell");
args::Positional<std::string> inputDirFlag(
parser, "databasePath", "Database path.", args::Options::Required);
args::HelpFlag help(parser, "help", "Display this help menu", {'h', "help"});
args::ValueFlag<std::string> inputDirFlag(
parser, "", "Database path.", {'i', "inputDir"}, args::Options::Required);
args::ValueFlag<uint64_t> bpSizeInMBFlag(parser, "",
"Size of buffer pool for default and large page sizes in megabytes", {'d', "defaultBPSize"},
-1u);
Expand Down