New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace getRawName with toString #1324

Merged

andyfengHKU merged 1 commit into master from expression-raw-name

Feb 26, 2023

Contributor

andyfengHKU commented Feb 26, 2023 •

edited

Loading

This PR removes rawName field from expression. This field has been creating problems because we either

forget to set this field (or a bulk expression constructor if we want to ensure rawName to be always set); or
don't have this field because some expression is added by us (e.g. casting);

This leads to weird behaviour e.g. some operator prints empty parameter info.

This PR replace rawName with a getString virtual function so that the string of current expression can be inferred from its children expressions.


          replace getRawName with toString

a0a8ed9

andyfengHKU requested a review from ray6080

February 26, 2023 16:45

ray6080 approved these changes

View reviewed changes

andyfengHKU merged commit f8cbe3e into master

andyfengHKU deleted the expression-raw-name branch

February 26, 2023 18:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment