Arithmetic function framework refactor #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
requested changes
Feb 22, 2023
| executeOnValue<OPERAND_TYPE, RESULT_TYPE, FUNC, OP_WRAPPER>( | ||
| operand, pos, resultValues[pos], result); | ||
| executeOnValue<OPERAND_TYPE, RESULT_TYPE, FUNC, OP_WRAPPER>(operand, pos, | ||
| resultValues[result.state->selVector->selectedPositions[0]], result); |
There was a problem hiding this comment.
why are we changing this?
There was a problem hiding this comment.
This is a bug in the executor.
The result and source vector may not have the same state
There was a problem hiding this comment.
ok. Can u then in this function create local variable inputPos and resultPos and check unaryExecute/SelectSwitch as well as unary boolean executor?
I think we have the same problem across these two places
acquamarin
force-pushed
the
function-framework-refactor
branch
from
069ede1
to
660c800
Compare
andyfengHKU
approved these changes
Feb 23, 2023
| executeOnValue<OPERAND_TYPE, RESULT_TYPE, FUNC, OP_WRAPPER>( | ||
| operand, pos, resultValues[pos], result); | ||
| executeOnValue<OPERAND_TYPE, RESULT_TYPE, FUNC, OP_WRAPPER>(operand, pos, | ||
| resultValues[result.state->selVector->selectedPositions[0]], result); |
There was a problem hiding this comment.
ok. Can u then in this function create local variable inputPos and resultPos and check unaryExecute/SelectSwitch as well as unary boolean executor?
I think we have the same problem across these two places
acquamarin
force-pushed
the
function-framework-refactor
branch
from
660c800
to
ea5d274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current arithmetic function framework.