Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework header file to get rid of using namespace #1248

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Rework header file to get rid of using namespace #1248

merged 1 commit into from
Feb 7, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Feb 7, 2023

Sorry for the monstrous PR 😄
We're setting the principle of not introducing using namespace in all header files, and also no using namespace std in cpp files.

@ray6080 ray6080 changed the title Rework header file to get rid of using namespace Rework header file to get rid of using namespace Feb 7, 2023
@ray6080 ray6080 merged commit 37a9e84 into master Feb 7, 2023
@ray6080 ray6080 deleted the header branch February 7, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewim mewim mewim approved these changes

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ray6080 @mewim @andyfengHKU