Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multiple src/dst nodetable support #1241

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Remove multiple src/dst nodetable support #1241

merged 1 commit into from
Feb 7, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Feb 6, 2023 •
edited

Solves issue #1221 :

  1. This PR removes the support of multiple src/dst tables in a relation.
    (e.g. we no longer support relation like: (person|animal)-[:knows]->(person)).
  2. Refactors test files.

andyfengHKU
andyfengHKU reviewed Feb 6, 2023
View reviewed changes
src/include/storage/storage_structure/in_mem_page.h Outdated Show resolved Hide resolved
src/include/storage/store/rel_table.h Show resolved Hide resolved
src/include/storage/store/rel_table.h Show resolved Hide resolved
src/storage/store/rel_table.cpp Show resolved Hide resolved
src/storage/store/rel_table.cpp Show resolved Hide resolved
test/test_files/tinysnb/agg/multi_label.test Show resolved Hide resolved
ray6080
ray6080 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upgrade project version to 0.0.1.4 in CMake file? So you can trigger an auto-reload of the benchmark dataset.

src/include/storage/copy_arrow/copy_rel_arrow.h Outdated Show resolved Hide resolved
src/include/storage/storage_structure/column.h Outdated Show resolved Hide resolved
src/include/storage/storage_structure/column.h Outdated Show resolved Hide resolved
src/include/storage/storage_structure/lists/lists.h Outdated Show resolved Hide resolved
src/include/storage/storage_structure/lists/lists.h Outdated Show resolved Hide resolved
src/include/storage/store/rels_statistics.h Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 9e722fe into master Feb 7, 2023
@acquamarin acquamarin deleted the reltable-refactor branch February 7, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU left review comments

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acquamarin @ray6080 @andyfengHKU