Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite ldbc snb queries #1227

Merged
merged 1 commit into from
Feb 5, 2023
Merged

rewrite ldbc snb queries #1227

merged 1 commit into from
Feb 5, 2023

Conversation

anuchak
Copy link
Collaborator

@anuchak anuchak commented Feb 1, 2023

No description provided.

@anuchak anuchak marked this pull request as ready for review February 3, 2023 02:15
@anuchak anuchak requested a review from mewim February 3, 2023 02:16
@anuchak
Copy link
Collaborator Author

anuchak commented Feb 3, 2023

#1204 - the results are now visible and the tests are passing: https://kuzu-benchmark.mew.im/run.html#831

@mewim
Copy link
Member

mewim commented Feb 3, 2023

Only Q32, Q34, and Q37 got logged into the benchmark results. Apparently Q36 and Q38 run out of memory. I would suggest to remove Q36 and Q38 and try again.

@mewim
Copy link
Member

mewim commented Feb 3, 2023

It seems that we actually have another issue in the benchmark runner: #1234. Maybe try to run the benchmarks again after this PR is merged.

Copy link
Member

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the queries passing on Benchmark Result Overview. Just change the two query's name to be consistent with the file name and I think we are good to merge.

benchmark/queries/ldbc-sf100/ldbc_snb_ic/q35.benchmark Outdated Show resolved Hide resolved
benchmark/queries/ldbc-sf100/ldbc_snb_ic/q36.benchmark Outdated Show resolved Hide resolved
@anuchak anuchak merged commit 8cc93cb into master Feb 5, 2023
@anuchak anuchak deleted the fix-1204 branch February 5, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants