Fix PyG converter crash when no property is extracted at all #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mewim
force-pushed
the
pyg-minor-fix
branch
2 times, most recently
from
7cb4435
to
120cd90
Compare
andyfengHKU
reviewed
Jan 31, 2023
| @@ -182,6 +183,8 @@ def __mark_property_unconverted(self, label, prop_name): | |||
| def __populate_edges_dict(self): | |||
| # Post-process edges, map internal ids to positions | |||
| for r in self.rels: | |||
| if (r[0], r[1]) not in self.internal_id_to_pos_dict or (r[2], r[3]) not in self.internal_id_to_pos_dict: | |||
There was a problem hiding this comment.
Seems there should be a warning here because it only happens when user fail to return the src/dst node for a rel which is an undefined behaviour (when converting to pyg) in my opinion. Up to u to decide.
There was a problem hiding this comment.
I just realized that now with the behavior of returning unconverted properties, it makes more sense to always return the full graph structure regardless of whether the properties can be converted. If no property is converted, the position will correspond to the index of unconverted properties lists. So I have removed this check and always maintain the mappings regardless if whether a property can be extracted. I also added a test case for this.
andyfengHKU
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.