Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 1203 #1223

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix issue 1203 #1223

merged 1 commit into from
Feb 2, 2023

Conversation

acquamarin
Copy link
Collaborator

Fixes issue #1203
The node copier now correctly initialize the list headers for the newly added nodes.

@acquamarin acquamarin closed this Jan 31, 2023
@acquamarin acquamarin reopened this Jan 31, 2023
@ray6080 ray6080 changed the title fix issue 1203 Fix issue 1203 Feb 1, 2023
ray6080
ray6080 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment: Let's not pass RelsStore to CopyNodeArrow, instead handle the batch initialization of empty rels for new nodes inside CopyNode operator.

@acquamarin acquamarin merged commit e5cc820 into master Feb 2, 2023
@acquamarin acquamarin deleted the fix-issue-1203 branch February 2, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acquamarin @ray6080