Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex match #1208

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Regex match #1208

merged 1 commit into from
Jan 31, 2023

Conversation

anuchak
Copy link
Collaborator

@anuchak anuchak commented Jan 27, 2023

No description provided.

@anuchak anuchak marked this pull request as ready for review January 28, 2023 00:30
@anuchak anuchak requested a review from ray6080 January 29, 2023 18:01
ray6080
ray6080 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @anuchak

src/include/common/expression_type.h Outdated Show resolved Hide resolved
src/include/function/string/operations/reg_expr_operation.h Outdated Show resolved Hide resolved
src/include/function/string/operations/reg_expr_operation.h Outdated Show resolved Hide resolved
src/include/function/string/vector_string_operations.h Outdated Show resolved Hide resolved
third_party/CMakeLists.txt Outdated Show resolved Hide resolved
test/test_files/tinysnb/function/string.test Outdated Show resolved Hide resolved
third_party/re2/bitstate.cpp Outdated Show resolved Hide resolved
test/test_files/tinysnb/function/string.test Show resolved Hide resolved
@anuchak anuchak merged commit 57a0b7b into master Jan 31, 2023
@anuchak anuchak deleted the regex branch January 31, 2023 17:51
@ray6080 ray6080 changed the title regex support for queries Regex match Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anuchak @ray6080