Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export query result to arrow: string data type #1199

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Export query result to arrow: string data type #1199

merged 1 commit into from
Jan 24, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jan 23, 2023

  • add support of string data type in arrow export
  • fix csv copy mismatch in py test (leading to changes of ground truth in df and networkx tests)
  • add more tests for arrow export

@ray6080 ray6080 requested a review from mewim January 23, 2023 23:24
mewim
mewim approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should probably add a test for UTF-8.

@ray6080 ray6080 merged commit a38477a into master Jan 24, 2023
@ray6080 ray6080 deleted the arrow branch January 24, 2023 21:24
@ray6080 ray6080 added the feature New features or missing components of existing features label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewim mewim mewim approved these changes

Assignees
No one assigned
Labels
feature New features or missing components of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ray6080 @mewim