Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction to add property statement #1194

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Add transaction to add property statement #1194

merged 1 commit into from
Jan 23, 2023

Conversation

acquamarin
Copy link
Collaborator

This PR adds transaction support to add property statement.

  1. The physical operator will call the appropriate storageUtil functions to create the wal version of the database file for the newly added property.
  2. During checkpointing, the walReplayer will rename the wal version of the database file to the original version. If the database crashes before committing, the walReplayer will delete the WAL version of the new property file.

ray6080
ray6080 approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/runner/e2e_ddl_test.cpp Outdated Show resolved Hide resolved
test/runner/e2e_ddl_test.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 299faf1 into master Jan 23, 2023
@acquamarin acquamarin deleted the add-property-trx branch January 23, 2023 03:09
@ray6080 ray6080 changed the title add transaction to add property statement Add transaction to add property statement Jan 29, 2023
@ray6080 ray6080 added feature New features or missing components of existing features and removed feature New features or missing components of existing features labels Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
feature New features or missing components of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acquamarin @ray6080