Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export query result (fixed sized values only) to arrow #1193

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Export query result (fixed sized values only) to arrow #1193

merged 1 commit into from
Jan 21, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jan 20, 2023 •
edited
Loading

  • add get_as_arrow(), support BOOL, INT64, DOUBLE, DATE, TIMESTAMP, INTERVAL.
  • rename getResultValue to getValue.

@ray6080 ray6080 requested a review from mewim January 20, 2023 05:09
@ray6080 ray6080 changed the title Export query result to arrow Export query result (fixed sized values only) to arrow Jan 20, 2023
mewim
mewim approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@mewim mewim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I am not very familiar with the internals of Arrow format though.

tools/python_api/test/test_arrow.py Outdated Show resolved Hide resolved
tools/python_api/requirements_dev.txt Outdated Show resolved Hide resolved
@ray6080 ray6080 merged commit 698ac85 into master Jan 21, 2023
@ray6080 ray6080 deleted the arrow branch January 21, 2023 02:41
@ray6080 ray6080 added the feature New features or missing components of existing features label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mewim mewim mewim approved these changes

Assignees
No one assigned
Labels
feature New features or missing components of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ray6080 @mewim